Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for all argument in upgrade plugin #2641

Merged
merged 4 commits into from
Nov 26, 2021

Conversation

joshrotenberg
Copy link
Contributor

Adds support for -a/--all to rebar3 plugins upgrade, replacing the no argument functionality with the all flag.

See #2583.

@joshrotenberg
Copy link
Contributor Author

shelltests failed. Did I miss a test case somewhere?

@ferd
Copy link
Collaborator

ferd commented Nov 5, 2021

shelltests failed. Did I miss a test case somewhere?

Shelltests are an external repo we have that validates integrations (https://github.com/tsloughter/rebar3_tests).

 Warning: Command:
rebar3 plugins
--- Expected
+++ Got
+   4   upgrade        Upgrade plugins.
-  23   upgrade        Upgrade plugins

:help_tests/help_tests.test:4: [Failed]
Warning: Command:
rebar3 help plugins
--- Expected
+++ Got
+   4   upgrade        Upgrade plugins.
-  31   upgrade        Upgrade plugins

The difference is a changed '.' in the output.

@ferd ferd merged commit 123dd80 into erlang:master Nov 26, 2021
@joshrotenberg joshrotenberg deleted the plugins-upgrade-all branch November 29, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants