Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTX_LOG macro option to top-level rebar.config #2757

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

shino
Copy link
Contributor

@shino shino commented Nov 16, 2022

Before this commit, rebar3 release outputs relx's info log without line breaks.
This commit adds RTX_LOG macro to relx's erl_opts.

Steps to reproduce:

  1. rebar3 new app foo
  2. cd foo
  3. Append {relx, [{release, {foo, "0.0.1"}, [kernel, sasl, stdlib, foo], []}]}.
  4. rebar3 release

At the step 4, expectation is that it outputs (reasonably) concise log lines, but it outputs:

% rebar3.head release
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling foo
Solving Release foo-0.0.1Resolved foo-0.0.1release: foo-0.0.1
     erts: 13.1.1
     goals:
          kernel
          sasl
          stdlib
          foo
     applications:
          {kernel,"8.5.1"}
          {stdlib,"4.1.1"}
          {sasl,"4.2"}
          {foo,"0.1.0"}
Assembling release foo-0.0.1...Release output dir /home/shino/g/rebar3/foo/_build/default/rel/fooRewriting .app file: /home/shino/g/rebar3/foo/_build/default/rel/foo/lib/kernel-8.5.1/ebin/kernel.appRewriting .app file: /home/shino/g/rebar3/foo/_build/default/rel/foo/lib/stdlib-4.1.1/ebin/stdlib.appRewriting .app file: /home/shino/g/rebar3/foo/_build/default/rel/foo/lib/sasl-4.2/ebin/sasl.appRewriting .app file: /home/shino/g/rebar3/foo/_build/default/rel/foo/lib/foo-0.1.0/ebin/foo.apprelease start script createdRelease successfully assembled: _build/default/rel/foo

Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get to this! Thanks a lot for the contribution!

@ferd ferd merged commit 69a5898 into erlang:main Dec 23, 2022
@shino shino deleted the add-rlx-log branch December 26, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants