rebar3_dialyzer_format: Add missing message formatting #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing message string formatting to `rebar3_dialyzer_format`.
I ran the following commands for finding missing messages
```
grep '^message_to_string' lib/dialyzer/src/dialyzer.erl | sed 's/message_to_string({\([a-z_]*\),.*/\1/g' | sort > /tmp/otp.txt
grep '^message_to_string' src/rebar_dialyzer_format.erl | sed 's/message_to_string({\([a-z_]*\),.*/\1/g' | sort > /tmp/rebar3.txt
```
The missing message types are `callback_not_exported`,
`contract_with_opaque` and `map_update`. We already have `invalid_contract`
but it has been divided in two functions in OTP project.
`race_condition` was deprecated in OTP-25.
```
diff /tmp/rebar3.txt /tmp/otp.txt
7a8
> callback_not_exported
17a19
> contract_with_opaque
27a30,31
> invalid_contract
> map_update
43d46
< race_condition
```
ferd
approved these changes
Feb 24, 2023
ferd
requested changes
Feb 24, 2023
| message_to_string({race_condition, [M, F, Args, Reason]}) -> | ||
| % race_conditions was deleted in OTP-25 | ||
| % https://github.com/erlang/otp/pull/5502 | ||
| message_to_string({race_conditions, [M, F, Args, Reason]}) -> |
There was a problem hiding this comment.
Actually, looking at the original PR, the atom was not plural. We need to keep it as-is for backwards compat https://github.com/erlang/otp/pull/5502/files#diff-14627674b25a85392c29df29ffc6934257ad6f8a2a502cdea3350a272236e883
There was a problem hiding this comment.
👍 I dropped the commit that contained the change.
gonzalobf
force-pushed
the
rebar3-dialyzer-format-add-missing-messages
branch
from
35466b1
to
9aa9f87
Compare
ferd
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing message string formatting to
rebar3_dialyzer_format.The messages are specify in the dialyzer.erl so I ran the following commands for finding missing messages:
The missing message types are
callback_not_exported,contract_with_opaque,map_update,missing_range. The file already have a message formatting forinvalid_contractbut it has been divided in two functions in OTP project so my command shows it.race_conditionwas deprecated in OTP-25.