Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REBAR_SRC_DIRS and REBAR_APP_DIRS fix by making rebar_dir:src_dirs/1 options default to ["src"] #2872

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

MarkoMin
Copy link
Contributor

@MarkoMin MarkoMin commented Mar 24, 2024

["src"] becomes the default for src_dirs. It was de facto standard because all calls to rebar_dir:src_dirs/2 were using it as a default.

Both REBAR_APP_DIRS and REBAR_SRC_DIRS are relative now. Note that those were undocumented for now so I think it's appropriate to change their values. REBAR_APP_DIRS previously pointed to non-existing directories anyways, same as REBAR_SRC_DIRS.

Changed the testcase to test whether all env variables are exported.

Closes #2869

@ferd ferd changed the title REBAR_SRC_DIRS and REBAR_APP_DIRS fix REBAR_SRC_DIRS and REBAR_APP_DIRS fix by making rebar_dir:src_dirs/1 options default to ["src"] Mar 25, 2024
Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny changes to sort of make sure we don't accidentally drop support for empty option sets, and then it's good to merge.

apps/rebar/test/rebar_dir_SUITE.erl Show resolved Hide resolved
apps/rebar/test/rebar_dir_SUITE.erl Show resolved Hide resolved
MarkoMin and others added 3 commits March 25, 2024 14:43
Co-authored-by: Fred Hebert <mononcqc@ferd.ca>
Co-authored-by: Fred Hebert <mononcqc@ferd.ca>
Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh if the rebar_dir:all_src_dirs/2 call no longer exists, I think we should bring it back. We don't know if plugins use it, in which case the plugins would stop working entirely.

misread the commit message's meaning

@ferd ferd merged commit 7ff5618 into erlang:main Mar 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REBAR_SRC_DIRS not available in hook
2 participants