Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider namespaces #70

Merged
merged 5 commits into from
Dec 21, 2014
Merged

Provider namespaces #70

merged 5 commits into from
Dec 21, 2014

Conversation

ferd
Copy link
Collaborator

@ferd ferd commented Dec 21, 2014

The following now works:

λ rebar3 → provider-namespaces* → ./rebar3 new
app (built-in): OTP Application
lib (built-in): OTP Library application (no processes)
plugin (built-in): Rebar3 plugin
release (built-in): OTP Release structure for executable programs

λ rebar3 → provider-namespaces* → ./rebar3 lfe new
===> Command do not found in namespace lfe

λ rebar3 → provider-namespaces* → ./rebar3 default new
app (built-in): OTP Application
lib (built-in): OTP Library application (no processes)
plugin (built-in): Rebar3 plugin
release (built-in): OTP Release structure for executable programs

λ rebar3 → provider-namespaces* → ./rebar3 default new, new
app (built-in): OTP Application
lib (built-in): OTP Library application (no processes)
plugin (built-in): Rebar3 plugin
release (built-in): OTP Release structure for executable programs
app (built-in): OTP Application
lib (built-in): OTP Library application (no processes)
plugin (built-in): Rebar3 plugin
release (built-in): OTP Release structure for executable programs

λ rebar3 → provider-namespaces* → ./rebar3 lfe new, new
===> Command do not found in namespace lfe

λ rebar3 → provider-namespaces* → ./rebar3 do new
app (built-in): OTP Application
lib (built-in): OTP Library application (no processes)
plugin (built-in): Rebar3 plugin
release (built-in): OTP Release structure for executable programs

Would need a merge and version up on the providers repo.

Attempt to address #69

No longer needed.
And more general namespace support
@ferd ferd mentioned this pull request Dec 21, 2014
@ferd
Copy link
Collaborator Author

ferd commented Dec 21, 2014

Trying to figure out failing tests

Using a namespace such as 'rebar3 lfe new' will look for the 'new'
command in 'lfe' namespace without the need for a 'do' provider to be
registered in that namespace.

Manually checked that 'rebar3 as <profile> <namespace> command' works,
as well with 'default' and 'do'.

Test suite still needed.
@ferd
Copy link
Collaborator Author

ferd commented Dec 21, 2014

If we agree with this form of implementation, I'll go and try to add tests for error output and correct functioning -- I've just done hand-tests before.

@tsloughter
Copy link
Collaborator

I think it looks good. Want to merge it in and I'll modify erlydtl provider to work with it?

@ferd
Copy link
Collaborator Author

ferd commented Dec 21, 2014

I'll try to add a few tests in before merging it. Hopefully won't be too long.

tsloughter added a commit that referenced this pull request Dec 21, 2014
@tsloughter tsloughter merged commit 3aeb76c into master Dec 21, 2014
@ferd ferd deleted the provider-namespaces branch May 6, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants