Add make release rule #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkgil
approved these changes
Apr 24, 2017
fenollp
reviewed
Apr 25, 2017
Makefile
Outdated
| @make rebar | ||
| @make ui | ||
| @make | ||
| @./bootstrap |
There was a problem hiding this comment.
I haven't tried this but you should be able to express dependencies better with
all: rebar
@$(REBAR) get-deps compile
...
release: all ui
@./bootstrapThere was a problem hiding this comment.
You're right. I did this way to allow echo before everything. Is there any way to write it your way and preserve echo?
There was a problem hiding this comment.
I don't think so and am not sure how useful that echo is, especially when you can see make release right above
There was a problem hiding this comment.
Probably you're right.
|
@baransu is it finished now? :) |
|
Yeah, I thinks so. Let's merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building Erlang Perf Lab manually requires few commands to run. I propose new rule which contains all commands which are necessary to run.
I'm not an Make expert so I'm counting on your review 馃檪