-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for latest #298
base: main
Are you sure you want to change the base?
Conversation
👋, @Schultzer. What tests are flaky in particular? (edit: maybe it was the word "flaky" that got me thinking, since it should mean that upon a re-run there's a possibility the flaky test passes; this would happen with the Windows installer issue, for example - if Erlang/OTP was resolved and e.g. 26.2.5.3 was released for Windows -, but not the I know that e.g. the installation on Windows, for 26.2.5.2 fails (I detected it in another repo.) and it seems that we're trying to have 27.0 resolved instead of 27.0.1, which is something recent. |
} else if (spec0 === 'latest') { | ||
version = versions0[versions0.latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, and the change below, do not seem related to the title of the pull request (talks about adding, not fixing). Why is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you take a look at the issue. Then you will see that currently there is a bug causing it to return 404, since we didn’t have any integration test, this was not caught.
Before
Erlang/OTP 27.0
After
Erlang/OTP OTP-27.0.1
The changes ensures that the proper version name is used and are tested.
Please notice the missing OTP-.
- otp-version: 'latest' | ||
elixir-version: 'latest' | ||
rebar3-version: 'latest' | ||
os: 'ubuntu-latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would mean that if e.g. OTP, Elixir or rebar3
were to fail in latest
the action's results would be affected (which we don't want). As an example, Erlang/OTP Windows 26.2.5.2 has issues installing (I don't know the origin of those), but that shouldn't affect the action's CI results (which I'm pretty sure the results for they won't because the issue in not in latest, but the previous concern still holds). Having CI fail and discussing fixes upstream should not be the action's concern.windows.yml
will show
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is your suggestion for an integration test?
On the other hand, if your changes to the code are required we'll still consider them, given that the PR title is adjusted. I'll briefly push to remove tests on Windows 26.2 and to fix the 27.0 comparison (since it was not being properly re |
@Schultzer, opened #299, in the meantime, and will re-run the tests 3/4 times to make sure there's no obvious flakiness. |
Maybe it would be beneficial to move the latest integration test into it’s own action, which could run nightly, and provide automated status for when the latest are working or not. |
Well, I would consider the 27.0 test flaky, if in the future it could match on 27.0.1. Which looks like what has happen. I have no idea why 26.2.5.2 is failing. |
Description
Add integration test.
@paulo-ferraz-oliveira, there are some flaky tests or a bug in the version resolution, which is unrelated to my changes.
Closes #297