Fix CI (don't use 26.2.5 on Windows; be strict when comparing versions) #299
+15
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
All of these pertain to properly testing over strict, otherwise (as is the case) Erlang/OTP releases 27.0.1 and our tests break because we're expecting 27 to resolve to 27.0.
26.2.5.2 (recently released) has an issue and exits with non-0
paulo-ferraz-oliveira
force-pushed
the
fix/tests
branch
from
72eff33
to
db89466
Compare
2 tasks
paulo-ferraz-oliveira
changed the title
Schultzer
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove Windows 26.2.5 from tests: (resolved) 26.2.5.2 is not installing properly, but the action's CI shouldn't be affected for this.
properly simulate
version-typestrictwhen required to not have e.g.27.0identify as (recently released)27.0.1when that's unexpected.Motivation
The motivation for this change was the report in #298, which made me look into why we had issues with version resolution. (issue is not in code, but tests' expectations)