Check presence of each beam listed in .app

[avnik]

This allow to build riak, because one of riak deps (node_package) have stuff in priv/ and valid node_package.app, but no one .beam files.

This patch not make relx ready to build riak releases (not yet), but I believe that checking beams by .app file better than finding any file in ebin

[ericbmerritt]

@avnik errors in Relx need to be pretty printable. take a look at include/relx.hrl. You need to wrap your errors in a ?RLX_ERROR macro and then add a format_error clause at the top.

You should do this every place you return an {error, ...}. there are a ton of examples of this in relx.

Btw, sorry this has taken so long to get to. I actually didn't notice the request. I really wish github had a better solution to notifications.

In any case, aside from the minor things I pointed out everything looks really good.

[ericbmerritt]

@avnik any updates?

[avnik]

On Mon, Jun 24, 2013 at 03:14:41PM -0700, Eric Merritt wrote:

@avnik any updates?

Not yet.
Hope to apply recommended fixes on this workdays.

[ericbmerritt]

@avnik thanks. I am just trying to stay on top of things. I am looking forward to this going in.

[ericbmerritt]

@avnik another ping

[avnik]

On Tue, Jun 18, 2013 at 09:37:27AM -0700, Eric Merritt wrote:

@avnik errors in Relx need to be pretty printable. take a look at
include/relx.hrl. You need to wrap your errors in a ?RLX_ERROR macro
and then add a format_error clause at the top.

I'm not introduce new errors, except {error, {missing_beam_file, Module,
File}} corrected by your suggestion. Should I replace all {error, ...}
with ?RLX_ERROR, even if I not touch them? (may be in separate commit?)

You should do this every place you return an {error, ...}. there are a ton of examples of this in relx.

Btw, sorry this has taken so long to get to. I actually didn't notice the request. I really wish github had a better solution to notifications.

I'm not so fast too.

PS Also I'm rebase my branch to recent master.

[ericbmerritt]

@avnik only fix the error you made. Not all of them :) sorry for the slow response. Let me know when you have rebased and I will merge.

[tsloughter]

What is up with this PR now @ericbmerritt ?

[ericbmerritt]

@tsloughter I was waiting for @avnik to fix the pr. but it looks like he isn't going to do it. If you want to grab his code and respond to that one thing I will merge it.

[jwilberding]

Is this still relevant or did you merge in his code @tsloughter?

[tsloughter]

Haven't touched it.

[tsloughter]

Moved to #42