Check presence of each beam listed in .app #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not yet tested. I opened the PR so @ericbmerritt could let me know if the correction for the format error is at least correct. Then I need to add to common test for it before we can merge. |
|
OK, I updated the skip apps tests and added a test for this. I think it is ready for merge... |
This allow to build riak, because one of riak deps (node_package) have stuff in priv/ and valid node_package.app, but no one .beam files.
|
Should be good now. |
ericbmerritt
added a commit
that referenced
this pull request
Sep 17, 2013
Check presence of each beam listed in .app
|
It works now, even without |
|
@nivertech Yup, now it checks that it has a beam file for all modules listed in the applications .app file. So if there are none listed it is still considered valid if there are no beam files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to build riak, because one of riak deps (node_package) have stuff
in priv/ and valid node_package.app, but no one .beam files.