Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from_string when the port is not specified #3

Closed
wants to merge 7 commits into from

Conversation

asv
Copy link

@asv asv commented Apr 17, 2013

Before fixing:

Eshell V5.10.1  (abort with ^G)
1> uri:from_string("http://test.com").
** exception error: bad argument
     in function  integer_to_list/1
        called as integer_to_list([])
     in call from uri:port_to_string/1 (src/uri.erl, line 459)
     in call from uri:to_iolist/1 (src/uri.erl, line 562)
     in call from uri:update_raw/1 (src/uri.erl, line 558)
2> 

@ericbmerritt
Copy link
Member

(Dead code elimination) e3de4a5 should be squashed with e2a56c3 (fix from_string when port is not specified)

@ericbmerritt
Copy link
Member

Other then that, this looks pretty good.

@asv
Copy link
Author

asv commented Apr 30, 2013

Sorry for bad pull request. I will go to refactor it and split up into multiple pull requests. Each of which belongs to it's own topic branch.

@asv asv closed this Apr 30, 2013
@ericbmerritt
Copy link
Member

@asv you can do that if you like. I am much more worried about small, consistent focused commits then I am about separate pull requests. In the end its the commits that matter most.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants