Some patches #63
Closed
Some patches #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #endif | ||
| } | ||
| } | ||
| catch (Exception ex) |
There was a problem hiding this comment.
Is it possible to narrow this exception type?
There was a problem hiding this comment.
Well the specific exception I was seeing was a SocketException, but is there really any value in letting any exception escape here?
added 4 commits
February 28, 2015 22:19
… same key already exists in the dictionary."
| @@ -205,7 +205,7 @@ protected virtual void OnConnectionMade (object sender, ConnectionMadeEventArgs | |||
| return; | |||
|
|
|||
| lock (this.connections) | |||
| this.connections.Add (e.Connection, ExecutionMode.ConnectionOrder); | |||
| this.connections [e.Connection] = ExecutionMode.ConnectionOrder; | |||
There was a problem hiding this comment.
Why? EDIT: I see your commit message for this. This really should never be an issue and seems like there's a larger bug at play that would be better to fix.
There was a problem hiding this comment.
Yeah, but I don't have any idea of what the larger bug could be. Any pointers? Here's the full trace, for the record:
System.ArgumentException: An element with the same key already exists in the dictionary.
at System.Collections.Generic.Dictionary`2[Tempest.IConnection,Tempest.ExecutionMode].Add (IConnection key, ExecutionMode value) [0x00000] in <filename unknown>:0
at Tempest.TempestServer.OnConnectionMade (System.Object sender, Tempest.ConnectionMadeEventArgs e) [0x00000] in <filename unknown>:0
at Tempest.Providers.Network.NetworkConnectionProvider.OnConnectionMade (Tempest.ConnectionMadeEventArgs e) [0x00000] in <filename unknown>:0
at Tempest.Providers.Network.NetworkConnectionProvider.Connect (Tempest.Providers.Network.NetworkServerConnection connection) [0x00000] in <filename unknown>:0
at Tempest.Providers.Network.NetworkServerConnection.OnTempestMessageReceived (Tempest.MessageEventArgs e) [0x00000] in <filename unknown>:0
at Tempest.Providers.Network.NetworkConnection.ReliableReceiveCompleted (System.Object sender, System.Net.Sockets.SocketAsyncEventArgs e) [0x00000] in <filename unknown>:0
at System.Net.Sockets.SocketAsyncEventArgs.OnCompleted (System.Net.Sockets.SocketAsyncEventArgs e) [0x00000] in <filename unknown>:0
at System.Net.Sockets.SocketAsyncEventArgs.ReceiveCallback (IAsyncResult ares) [0x00000] in <filename unknown>:0
at System.Net.Sockets.SocketAsyncEventArgs.DispatcherCB (IAsyncResult ares) [0x00000] in <filename unknown>:0
There was a problem hiding this comment.
Can you consistently reproduce this? If so, can you share the repro?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few patches I made while playing around. Hope they're helpful!