Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing main branch to compile and pass all tests with JDK11 #443

Merged
merged 2 commits into from Sep 26, 2022
Merged

Fixing main branch to compile and pass all tests with JDK11 #443

merged 2 commits into from Sep 26, 2022

Conversation

mareknovotny
Copy link
Collaborator

@mareknovotny mareknovotny commented Apr 27, 2022 •
edited

the latest PR CI with jdk11 which is a Jenkins CI default runtime jobs failed on

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0-jboss-1:compile (default-compile) on project errai-ioc: Compilation failure: Compilation failure: 
[ERROR] /home/jenkins/workspace/KIE/main/pullrequest/errai-main.pr/errai/errai-ioc/src/main/java/org/jboss/errai/ioc/rebind/ioc/bootstrapper/IOCProcessor.java:[50,24] cannot find symbol
[ERROR]   symbol:   class PostConstruct
[ERROR]   location: package javax.annotation
[ERROR] /home/jenkins/workspace/KIE/main/pullrequest/errai-main.pr/errai/errai-ioc/src/main/java/org/jboss/errai/ioc/rebind/ioc/bootstrapper/TypeFactoryBodyGenerator.java:[43,24] cannot find symbol
[ERROR]   symbol:   class PostConstruct
[ERROR]   location: package javax.annotation
[ERROR] /home/jenkins/workspace/KIE/main/pullrequest/errai-main.pr/errai/errai-ioc/src/main/java/org/jboss/errai/ioc/rebind/ioc/bootstrapper/TypeFactoryBodyGenerator.java:[44,24] cannot find symbol
[ERROR]   symbol:   class PreDestroy
[ERROR]   location: package javax.annotation
[ERROR] /home/jenkins/workspace/KIE/main/pullrequest/errai-main.pr/errai/errai-ioc/src/main/java/org/jboss/errai/ioc/rebind/ioc/bootstrapper/IOCProcessor.java:[792,39] cannot find symbol
[ERROR]   symbol:   class PostConstruct
[ERROR]   location: class org.jboss.errai.ioc.rebind.ioc.bootstrapper.IOCProcessor
[ERROR] /home/jenkins/workspace/KIE/main/pullrequest/errai-main.pr/errai/errai-ioc/src/main/java/org/jboss/errai/ioc/rebind/ioc/bootstrapper/TypeFactoryBodyGenerator.java:[274,84] cannot find symbol
[ERROR]   symbol:   class PreDestroy
[ERROR]   location: class org.jboss.errai.ioc.rebind.ioc.bootstrapper.TypeFactoryBodyGenerator
[ERROR] /home/jenkins/workspace/KIE/main/pullrequest/errai-main.pr/errai/errai-ioc/src/main/java/org/jboss/errai/ioc/rebind/ioc/bootstrapper/TypeFactoryBodyGenerator.java:[297,91] cannot find symbol
[ERROR]   symbol:   class PostConstruct
[ERROR]   location: class org.jboss.errai.ioc.rebind.ioc.bootstrapper.TypeFactoryBodyGenerator
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0-jboss-1:compile (default-compile) on project errai-ioc: Compilation failure
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: Compilation failure
    at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute (AbstractCompilerMojo.java:1215)
    at org.apache.maven.plugin.compiler.CompilerMojo.execute (CompilerMojo.java:196)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

fixing it by switching from test to compile scoped for jakarta.annotation-api dependency

mbiarnes
mbiarnes approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@mbiarnes mbiarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mareknovotny
Copy link
Collaborator Author

jenkins retest this please

@mareknovotny
Copy link
Collaborator Author

added a fix for NCFE in demos

@mbiarnes
Copy link
Contributor

mbiarnes commented Sep 7, 2022

Jenkins retest this

@mbiarnes
Copy link
Contributor

mbiarnes commented Sep 7, 2022

Jenkins run jdk8

1 similar comment
@mbiarnes
Copy link
Contributor

mbiarnes commented Sep 7, 2022

Jenkins run jdk8

@mareknovotny mareknovotny changed the title changing scope of dependency to compile Fixing main branch to compile and pass all tests with JDK11 Sep 7, 2022
@mareknovotny
Copy link
Collaborator Author

Jenkins run jdk8

@mareknovotny
Copy link
Collaborator Author

Jenkins run jdk8

mbiarnes
mbiarnes approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@mbiarnes mbiarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mareknovotny
Copy link
Collaborator Author

mareknovotny commented Sep 23, 2022 •
edited

ok, i squashed commits and finally programmatically skip AnnotationEncoderTest test as not stable enough for multiple jdks, It runs only on jdk 11+

@mareknovotny mareknovotny force-pushed the errai-fix-dep branch 2 times, most recently from f93d1fb to 6f3018a Compare September 23, 2022 13:15
@mareknovotny mareknovotny merged commit 4958750 into errai:main Sep 26, 2022
@mareknovotny mareknovotny deleted the errai-fix-dep branch September 26, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbiarnes mbiarnes mbiarnes approved these changes

@tiagobento tiagobento Awaiting requested review from tiagobento

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mareknovotny @mbiarnes