Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.4 breaks config setup #754

Closed
1 task done
fviolette opened this issue Jan 15, 2024 · 1 comment
Closed
1 task done

3.0.4 breaks config setup #754

fviolette opened this issue Jan 15, 2024 · 1 comment

Comments

@fviolette
Copy link

fviolette commented Jan 15, 2024

Check for existing issues

  • Completed

Environment

OS: macOS
Install method: Howbrew
Vale version: 3.0.4

Describe the bug / provide steps to reproduce it

My vale.ini file is located at the repo root. I don't use Vocabularies.
My StylesPath folder content:

  • Contentsquare folder with vale .yml files
  • fixtures folder with .md/.mdx testing selected rules

Upgrading to 3.0.4 breaks my BlockIgnores as specified in this config file:

StylesPath = vale-styles
MinAlertLevel = suggestion

SkippedScopes = table

[formats]
mdx = md

[*.md]
BasedOnStyles = Contentsquare
BlockIgnores = (?s) *(<TabItem [^>]*>.*?</?TabItem>), (?s) *(\{\/\*.*?\*\/\}), \
(?s) *(export.*?\n), (?s) *(\{\/\* vale off \*\/\}.*\{\/\* vale on \*\/\})

Contentsquare.HeaderGerunds = NO

[*README.md]

Vale.Spelling = NO
Contentsquare.Admonitions = NO

Running vale src/content/docs/en gives:

...
 src/content/docs/en/webview-tracking-web-tag/error-analysis.mdx
 84:19  error  "r (" must contain one and      Contentsquare.SentenceSpacing 
               only one space.                                               
 85:23  error  "r (" must contain one and      Contentsquare.SentenceSpacing 
               only one space.                                               
 90:28  error  "r (" must contain one and      Contentsquare.SentenceSpacing 
               only one space.                                               
 91:27  error  "r (" must contain one and      Contentsquare.SentenceSpacing 
               only one space.                                               
 92:31  error  "r (" must contain one and      Contentsquare.SentenceSpacing 
               only one space.                                               

✖ 167 errors, 1815 warnings and 0 suggestions in 1450 files.
error Command failed with exit code 1.

I had 0 errors, 0 warnings and 0 suggestions in 1450 files with 3.0.3.

Thanks for your support

@fviolette fviolette changed the title 3.0.4 breaks BlockIgnores 3.0.4 breaks config setup Jan 15, 2024
@fviolette
Copy link
Author

Thanks for your reactivity @jdkato!

@jdkato jdkato closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants