Merge pull request #860 from mallowlabs/add_url_to_webhook

Add url to webhook service
errbit · Mar 21, 2015 · 3c9449a · 3c9449a
2 parents 1b1b525 + 6574b74
commit 3c9449a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/app/models/notification_services/webhook_service.rb b/app/models/notification_services/webhook_service.rb
@@ -13,7 +13,11 @@ def check_params
     end
   end
 
+  def message_for_webhook(problem)
+    {:problem => {:url => problem_url(problem)}.merge(problem.as_json).to_json}
+  end
+
   def create_notification(problem)
-    HTTParty.post(api_token, :body => {:problem => problem.to_json})
+    HTTParty.post(api_token, :body => message_for_webhook(problem))
   end
 end
diff --git a/spec/models/notification_service/webhook_service_spec.rb b/spec/models/notification_service/webhook_service_spec.rb
@@ -4,7 +4,8 @@
     notification_service = Fabricate :webhook_notification_service, :app => notice.app
     problem = notice.problem
 
-    expect(HTTParty).to receive(:post).with(notification_service.api_token, :body => {:problem => problem.to_json}).and_return(true)
+    payload = notification_service.message_for_webhook(problem)
+    expect(HTTParty).to receive(:post).with(notification_service.api_token, :body => payload).and_return(true)
 
     notification_service.create_notification(problem)
   end