Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript not works with jquery 1.10 #500

Closed
shingara opened this issue Jun 8, 2013 · 1 comment
Closed

Javascript not works with jquery 1.10 #500

shingara opened this issue Jun 8, 2013 · 1 comment
Assignees
@shingara
Labels
bug
Milestone
0.1.1

Comments

@shingara
Copy link
Member

shingara commented Jun 8, 2013

Since commit 2be92c1 several javascript doesn't works because it's not compatible to jquery 1.10
@ghost ghost assigned shingara Jun 8, 2013
shingara added a commit that referenced this issue Jun 9, 2013
@shingara
Fix issue with Jquery >= 1.9
7993d1c 
See #500
@shingara
Copy link
Member Author

shingara commented Jun 9, 2013

Master has all Javascript works. But there are a lot of issue with jQuery >= 1.9.

The rails.js javascript is not the default. You can see some information about that in the rails/jquery-ujs#196 so we can't upgrade to the official rails-jquery gem because it was not merged.

If we want upgrade to the Jquery >= 1.9 we need override the $.rails.confirm like explain on comment in commit : rails/jquery-ujs@8063d1d

@shingara shingara closed this as completed Jun 9, 2013
@shingara shingara mentioned this issue Jun 9, 2013
Closed
opsidao pushed a commit to opsidao/errbit that referenced this issue Jul 8, 2013
@shingara
Fix issue with Jquery >= 1.9
5fdb054 
See errbit#500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shingara shingara

Labels
bug
Projects
None yet
Milestone
0.1.1
Development

No branches or pull requests
1 participant
@shingara