Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icon for slack #1076

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Add icon for slack #1076

merged 1 commit into from
Apr 22, 2016

Conversation

ebeigarts
Copy link
Contributor

screen shot 2016-03-23 at 10 35 59

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.357% when pulling 48232f5 on mak-it:slack-icon into 6ef6993 on errbit:master.

stevecrozz
stevecrozz reviewed Apr 21, 2016
View reviewed changes
spec/models/notification_service/slack_service_spec.rb
# setup
problem = notice.problem

# faraday stubbing
payload = {
username: "Errbit",
icon_emoji: ":collision:",
icon_url: "https://raw.githubusercontent.com/errbit/errbit/master/docs/notifications/slack/errbit.png",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this normal? It seems a little strange to load the icon through raw.githubusercontent.com. Wouldn't it be more normal to put the icon in the errbit application and let errbit host it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the only argument is that errbit could be installed behind a firewall etc, and in that case it wouldn't work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I guess if github doesn't mind us hotlinking like this then its fine with me.

@stevecrozz stevecrozz merged commit 78c859f into errbit:master Apr 22, 2016
nofxx pushed a commit to fireho/errbit that referenced this pull request Jun 22, 2016
@ebeigarts @nofxx
Add icon for slack (errbit#1076)
96edfa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebeigarts @coveralls @stevecrozz