an empty [] for componets in jira throws an error if jira is configured ... #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to not add compents in ticket creation with fixes errbit#529
|
Changes Unknown when pulling dcb463e on maxstudener:master into * on errbit:master*. |
|
Could you add some tests for this situation ? (also I think the comment on line 84 is not necessary) |
|
Reading the code, the issue_component seems to be mandatory in Fields and check_params. Which case this issue_component is not define ? If it's really not mandatory. mark it like optional. |
|
I am working on the tests right now, ill make sure i take out the mandatory flag |
|
@maxstudener Is this issue something you plan to come back to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to not add compents in ticket creation with fixes #529