Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scope the type selector to the choose section #648

Merged
merged 1 commit into from
Feb 10, 2014
Merged

scope the type selector to the choose section #648

merged 1 commit into from
Feb 10, 2014

Commits on Feb 8, 2014

  1. scope the type selector to the choose section 

    Formerly if any input in the sub-menus had the substring 'type' in its
name, this event handler would have been bound to clicks on the input
element. When this happens, the variable 'chosen' would generally be an
empty string and that would result in an erroneous jQuery finder:
wrapper.find('div.'+section_class+'.'+chosen) causing an unhandled
error.

It looks like the intent is to bind only to the selectable choice icons,
so that's what this commit does and as a bonus, the embedded forms can
now have an input with the word 'type' in its name.
    @stevecrozz
    stevecrozz committed Feb 8, 2014
    Configuration menu
    Copy the full SHA
    a7dfa57 View commit details
    Browse the repository at this point in the history