Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: auto reconnect on kick for irc backend #72

Closed
nvdk opened this issue Sep 27, 2012 · 7 comments
Closed

feature request: auto reconnect on kick for irc backend #72

nvdk opened this issue Sep 27, 2012 · 7 comments

Comments

@nvdk
Copy link

nvdk commented Sep 27, 2012

Err sometimes gets kicked for flooding on our channel, it would be nice if there was an auto reconnect option

@aadis
Copy link
Contributor

aadis commented Oct 11, 2013

+1

2 similar comments
@dmsimard
Copy link

+1

@plarivee
Copy link

+1

@gbin gbin closed this as completed in 969b70b Jul 22, 2015
@gbin
Copy link
Member

gbin commented Jul 22, 2015

This is by default 5 seconds but can be set from the config file.

Thanks for your patience on this one !

@dmsimard
Copy link

Hey gbin, there is in an important distinction between re-joining after being kicked from a channel and being disconnected (e.g, connection reset by peer, flooding). This commit looks like it addresses being kicked and not the latter. The latter would be particularly interesting :)

@gbin
Copy link
Member

gbin commented Jul 22, 2015

@dmsimard indeed, 2 separate problems, we have an internal mechanism for all the backends for that, it looks like the IRC one doesn't use it, I am looking into it.

gbin added a commit that referenced this issue Jul 22, 2015
This was always here but at 60s. For comment on #72.
gbin added a commit that referenced this issue Jul 22, 2015
Plus a fix if the disconnection happens during a message send.
This is related to #72.
@gbin
Copy link
Member

gbin commented Jul 22, 2015

@dmsimard, here we go, done.

The first issue was a long 60s wait to reconnect after disconnection. (now it is a setting + defaults at 5s)

Then we were not calling the disconnect_callback so Err did not know we lost our presence on the rooms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants