Plugin breaks when multiple instances of same plugin found

[asfaltboy]

We should probably have a detection precedence when searching for plugin to load:

• local plugin dir
• custom plugin dir
• github maintained plugin dir

[sijis]

What order does it match now?
Also which errbot version?

[asfaltboy]

Honestly, I have no clue! Yapsy is a weird creature, and I couldn't follow the code to understand how errbot's BotPluginManager really loads all the plugins. Regardless, it's less about the order and more that it might count the same plugin in different locations multiple times (it should only allow a unique plugin to be loaded once).

[sijis]

Gotcha. To be clear, the issue is that the same plugin is found in multiple locations (and loaded), so your suggestion is to find it (via a precedence order) and load it once.

[asfaltboy]

Correct, at least as far as I understand the cause

On Sun, Oct 16, 2016, 19:09 Sijis Aviles notifications@github.com wrote:

Gotcha. To be clear, the issue is that the same plugin is found in
multiple locations (and loaded), so your suggestion is to find it (via a
precedence order) and load it once.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#870 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATn8DMl5tL8Hem8Abwv7xJMbenetj4fks5q0lpcgaJpZM4KV1HN
.

[sijis]

Last thing. Python and errbot version

[asfaltboy]

Python 3.5.1, errbot version 9.9.9 (checked out from git, commit f2af0d7)

[sijis]

yapsy is no longer managing plugins, so its likely this issue has been resolved.
If not, a new issue can be opened with newer data.