-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cascade dependency plugins #1519
Merged
sijis
merged 6 commits into
errbotio:master
from
Nov1kov:fix_cascade_dependency_plugins
Jul 11, 2021
Merged
Fix cascade dependency plugins #1519
sijis
merged 6 commits into
errbotio:master
from
Nov1kov:fix_cascade_dependency_plugins
Jul 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you think this bug and fix is also related to #1505? |
If you can, that would be extremely helpful. |
|
@sijis code-style fixed! |
I should have from free cycles this weekend to look at this more in-depth. |
2088a2b
to
bcd7f1e
Compare
Thank you again for the fixes. I truly appreciate the amount of testing included. |
sijis
added a commit
that referenced
this pull request
Jun 11, 2022
* reproduce bug by unittest * fix lose sub depends * fix unit tests for linux systems * add unit test from #1397 * fix codestyle * docs: Add fixes to CHANGES Co-authored-by: Ivan Novikov <i.novikov@cardsmobile.ru> Co-authored-by: Sijis Aviles <sijis.aviles+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug reproduce
Complicated plugin structure.
It works correctly after load on my MacBook. But didn't after deploy & run in Docker on a Linux machine.
Plugin "Parent1" can't find Childs plugins, by method
get_plugin
.Research
This behavior depends on a file system. Method
pathlib.Path.glob
works differently on Linux & Mac. Bot load plugins depending on the order of the files.PluginManager can activate plugins by direct load, or if the plugin is DependOn. So if the plugin activates by the second way, the plugin doesn't set depends list.
Merge request
_activate_plugin_dependencies
inPluginManager
.