refactor: detecting entry point plugins #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijis
force-pushed
the
fix/entrypoint_error
branch
from
6d858ae
to
0b444ad
Compare
This seems like the correct attribute to use, as it notes the actual path of the module.
nzlosh
pushed a commit
to nzlosh/errbot
that referenced
this pull request
Feb 4, 2023
* refactor: detecting entry point plugins * fix: deprecation warning on invalid escape sequence * style: format files * fix: use entrypoint name object instead of module * fix: using module instead of name attribute This seems like the correct attribute to use, as it notes the actual path of the module. * refactor: use pkg_resources instead of importlib metadata * test: clean up entry_point tests * test: use more common tox variable * docs: add description to CHANGES * style: format files
sijis
added a commit
to sijis/errbot
that referenced
this pull request
Jan 1, 2024
* refactor: detecting entry point plugins * fix: deprecation warning on invalid escape sequence * style: format files * fix: use entrypoint name object instead of module * fix: using module instead of name attribute This seems like the correct attribute to use, as it notes the actual path of the module. * refactor: use pkg_resources instead of importlib metadata * test: clean up entry_point tests * test: use more common tox variable * docs: add description to CHANGES * style: format files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a different way to detect entry point plugins.
This should fix #1629.