Allow optional username for IRC backend. #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For servers where nickname and username are different, allow passing in a different username. If username is not supplied, it's defaulted to nickname.
gbin
added a commit
that referenced
this pull request
Jun 22, 2014
Allow optional username for IRC backend.
|
Thx for splitting it up ! |
|
How about the other one (Unicode error)? That was a while ago. I dug inside the XML parser and there seemed no easy way to fix it. So reluctantly I made the exception hack. |
|
I think the fix should be in the construction of various Message() in irc.py. Here we should make sure it is already converted correctly to unicode there. |
zoni
pushed a commit
to zoni/errbot
that referenced
this pull request
Jun 24, 2014
This documents the added functionality from errbotio#256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For servers where nickname and username are different, allow passing in
a different username. If username is not supplied, it's defaulted to
nickname.