irc: Fix random UnicodeDecodeErrors
#570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In errbotio#569 it was reported that `UnicodeDecodeError`s are thrown randomly when the IRC backend is used. This commit tries to resolve this situation by using a replacement character for unrecognized byte sequences as described at https://pypi.python.org/pypi/irc Signed-off-by: mr.Shu <mr@shu.io>
| # Decode all input to UTF-8, but use a replacement character for | ||
| # unrecognized byte sequences | ||
| # (as described at https://pypi.python.org/pypi/irc) | ||
| self.connection.buffer_class.errors = 'replace' |
|
I think this is a sane thing to do. With no way to reliably determine the used encoding, assuming utf-8 seems the best bet as it is slowly becoming the de-facto encoding used for interoperability. |
zoni
added a commit
that referenced
this pull request
Dec 28, 2015
irc: Fix random `UnicodeDecodeError`s
zoni
added a commit
that referenced
this pull request
Dec 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnicodeDecodeErrors are thrown randomlywhen the IRC backend is used. This commit tries to resolve this
situation by using a replacement character for unrecognized byte
sequences as described at https://pypi.python.org/pypi/irc
Signed-off-by: mr.Shu mr@shu.io
Note that this should fix #569.