Allow ACLs on entire plugins and wildcard commands #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that all the settings defined in ACCESS_CONTROLS_DEFAULT are applied to each command listed in ACCESS_CONTROLS. If a certain command should to override the default set in ACCESS_CONTROLS_DEFAULT, it must be explicitly set up. This is more natural and more intuitive, removing the need to specify the default for every single command where you define other rules.
This modifies ACLs in two ways. 1. Wildcards are now supported, so `status*` will match `!status` as well as `!status_plugins`, etc. 2. ACLs can include the plugin name by placing it in front of the command, separated by a colon (`:`). For example, `Health:status` will match the `!status` command of the `Health` plugin and `Health:*` will match all commands defined by the `Health` plugin.
gbin
added a commit
that referenced
this pull request
Mar 10, 2016
Allow ACLs on entire plugins and wildcard commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies ACLs in three ways.
Wildcards are now supported, so
status*will match!statusaswell as
!status_plugins, etc.ACLs can include the plugin name by placing it in front of the
command, separated by a colon (
:). For example,Health:statuswillmatch the
!statuscommand of theHealthplugin andHealth:*willmatch all commands defined by the
Healthplugin.This ensures that all the settings defined in ACCESS_CONTROLS_DEFAULT
are applied to each command listed in ACCESS_CONTROLS. If a certain
command wants to override the default set in ACCESS_CONTROLS_DEFAULT,
it must be explicitly set up.
This is more natural and more intuitive, removing the need to specify
the default for every single command where you define other rules.
Closes #442.