Rename http_req_duration_seconds to http_request_duration_seconds #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errm
force-pushed
the
errm/http_request_consistency
branch
2 times, most recently
from
454cfb3
to
bcc332c
Compare
This is to maintain consistency with commonly in use metric names from other exporters. For consistency I have also renamed http_req_queue_time_seconds e.g. when using sloth we will be able to make use of the slok-go-http-metrics plugin without modifications This is a breaking change: dashboards & alerting / recording rules using these metrics will need to be updated.
errm
force-pushed
the
errm/http_request_consistency
branch
from
bcc332c
to
ad7567f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to maintain consistency with commonly in use metric names
from other exporters.
For consistency I have also renamed http_req_queue_time_seconds
e.g. when using sloth we will be able to make use of
the slok-go-http-metrics plugin without modifications
This is a breaking change: dashboards & alerting / recording rules
using these metrics will need to be updated.