Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to upstream version of prometheus-client #5

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Conversation

errm
Copy link
Owner

@errm errm commented Aug 29, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #5 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage    99.9%   99.91%   +<.01%     
==========================================
  Files          14       14              
  Lines        1071     1144      +73     
==========================================
+ Hits         1070     1143      +73     
  Misses          1        1
Impacted Files Coverage Δ
lib/promenade/kafka/connection_subscriber.rb 100% <100%> (ø) ⬆️
spec/kafka_spec.rb 100% <100%> (ø) ⬆️
lib/promenade/kafka/consumer_subscriber.rb 100% <100%> (ø) ⬆️
lib/promenade/setup.rb 100% <100%> (ø) ⬆️
spec/setup_spec.rb 100% <100%> (ø) ⬆️
lib/promenade/kafka/async_producer_subscriber.rb 100% <100%> (ø) ⬆️
spec/promenade_spec.rb 100% <100%> (ø) ⬆️
lib/promenade/kafka/fetcher_subscriber.rb 100% <100%> (ø) ⬆️
spec/prometheus_spec.rb 100% <100%> (ø) ⬆️
lib/promenade/kafka/subscriber.rb 100% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7614be0...3420ffe. Read the comment docs.

@errm errm merged commit 8fab6a9 into master Dec 17, 2019
@errm errm deleted the use-upstream-client branch December 17, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants