Add a test stage to our Docker Build and Push workflow #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two new steps to the workflow, namely, buildForTest, and testBuiltImage. The `buildForTest` step only builds an amd64 image with the latest tag since we test this image through the ersilia CLI which only looks for the latest tag. The `testBuiltImage` serves the newly built model image and tests it against a simple input. Then I use jq to count the fields within the model outcome followed by checking for null values in the output. If there are any null values within the output this test fails and the model push will not succeed. Upon success of this test, the subsequent build stage will only build the arm64 image and reuse the previously built amd64 image and push them both to DockerHub.
DhanshreeA
added a commit
that referenced
this pull request
Apr 8, 2024
Added two new steps to the workflow, namely, buildForTest, and testBuiltImage. The `buildForTest` step only builds an amd64 image with the latest tag since we test this image through the ersilia CLI which only looks for the latest tag. The `testBuiltImage` serves the newly built model image and tests it against a simple input. Then I use jq to count the fields within the model outcome followed by checking for null values in the output. If there are any null values within the output this test fails and the model push will not succeed. Upon success of this test, the subsequent build stage will only build the arm64 image and reuse the previously built amd64 image and push them both to DockerHub. Also moved the installation of ersilia a few steps up to use within the testBuiltImage stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new steps to the workflow, namely, buildForTest, and testBuiltImage.
The
buildForTeststep only builds an amd64 image with the latest tag since we test this image through the ersilia CLI which only looks for the latest tag.The
testBuiltImageserves the newly built model image and tests it against a simple input. Then I use jq to count the fields within the model outcome followed by checking for null values in the output. If there are any null values within the output this test fails and the model push will not succeed.Upon success of this test, the subsequent build stage will only build the arm64 image and reuse the previously built amd64 image and push them both to DockerHub.