Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a streamlit app for ersilia model #126

Closed
Amna-28 opened this issue Apr 4, 2022 · 9 comments
Closed

Add a streamlit app for ersilia model #126

Amna-28 opened this issue Apr 4, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@Amna-28
Copy link
Contributor

Amna-28 commented Apr 4, 2022

What is your feature request?
Develop a streamlit app for ersilia model for better user experience

Is your feature request related to a problem?
No, it could be just an enhancement

Describe alternatives you've considered
with Ersilia model app, the user could select the model to run, choose api, fetch models, display catalog, request a cleanup (delete unused models in local machine) all in one place.

Additional context
This will improve the usability of ersilia.
I was researching and found that multiple tabs could be incorporated into a streamlit app, using which we can also improve the display of catalog ( #12) Links to the github repositories could also be added for each model in the catalog. There are many more possibilities.

screenshot of a simple app is attached below, that I developed while attempting the application tasks.

Capture2

@Amna-28 Amna-28 added the enhancement New feature or request label Apr 4, 2022
@Amna-28
Copy link
Contributor Author

Amna-28 commented Apr 4, 2022

Hi @miquelduranfrigola ,
Please assign this task to me if you find it any useful. I would really enjoy working on it.

@GemmaTuron
Copy link
Member

@Amna-28 great work.

Link this to your issue thread as well please. I will let @miquelduranfrigola comment.
Something "nice to have" if the models work fine on streamlit is to show the representation of the molecular structure of the input (use the rdkit python library for example)

@Amna-28
Copy link
Contributor Author

Amna-28 commented Apr 5, 2022

Thanks @GemmaTuron ,
Sure thing, I will add the link and start working on it.
Thanks for your feedback!

@Amna-28
Copy link
Contributor Author

Amna-28 commented Apr 5, 2022

Hi @GemmaTuron
Keeping your suggestion in mind, are you talking about something like this?

image

@Amna-28
Copy link
Contributor Author

Amna-28 commented Apr 5, 2022

@GemmaTuron Can I consider this as a new idea mentioned in "other" section of the application as:
Add a comment in this issue with your new idea, tagging the mentor

can I mark it referencing this issue?

@miquelduranfrigola
Copy link
Member

Hi, @Amna-28 this is quite awesome!

A few suggestions:

  • Not all models have all APIs, so it would be great that the radio buttons in the "select API" are dynamic, depending on the available APIs for the model. If you are using the ErsiliaModel class, it has a get_apis method that can help.
  • It is OK to see the output in JSON format, but I think it is best if you just display the "output" part of it. No need for "input", "key", "text", etc.

What do you think?

@GemmaTuron
Copy link
Member

I @Amna-28

Yes this is what I had in mind great job! This can be considered a new idea sure, no need to open an issue though since you are already solving it.

@Amna-28
Copy link
Contributor Author

Amna-28 commented Apr 7, 2022

@miquelduranfrigola Thank you for your suggestions, yes that would be better to just show the output part. Also I will make use of get_apis method to display api available in the model selected.

@Amna-28
Copy link
Contributor Author

Amna-28 commented Apr 7, 2022

I @Amna-28

Yes this is what I had in mind great job! This can be considered a new idea sure, no need to open an issue though since you are already solving it.

Got it, thank you @GemmaTuron for your continuous support and feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants