Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add streamlit app ersilia-app.py #166

Merged
merged 3 commits into from
Apr 9, 2022

Conversation

Amna-28
Copy link
Contributor

@Amna-28 Amna-28 commented Apr 6, 2022

I have created a simple streamlit app as suggested in issue #126
It has multi-page view that could be used to extend its functionality.
Right now user can choose a model and perform predict and calculate operations on the given input string and display the output.
It also shows the representation of the molecular structure of the input using the rdkit python library as suggested by @GemmaTuron
I would love to hear your feedback and work on your suggestions.

image

@Amna-28 Amna-28 mentioned this pull request Apr 6, 2022
26 tasks
@miquelduranfrigola
Copy link
Member

Hi, @Amna-28 this is quite nice! Please see my suggestions in #126
I am happy to accept your PR as is. So please do not implement these changes if you do not have time at the moment :)
Just let me know

@Amna-28
Copy link
Contributor Author

Amna-28 commented Apr 7, 2022

Hi @miquelduranfrigola
Keeping your suggestions in mind, I have made changes and commited those changes to the branch.
Now it shows buttons for api supported by the model that is selected from the drop-down.
Also now it displays the output part only instead of json.
Please have a look at the screenshots

Capture4
Capture5

@miquelduranfrigola
Copy link
Member

This is quite amazing, @Amna-28, well done!

A few things:

  • May I request that you place these files under ersilia/app/contrib/?
  • Can we round the output to 3 decimals?

@Amna-28
Copy link
Contributor Author

Amna-28 commented Apr 8, 2022

Thank you @miquelduranfrigola ,
Yes sure I will do that.

@Amna-28
Copy link
Contributor Author

Amna-28 commented Apr 8, 2022

Hi @miquelduranfrigola , I see a problem in my app, the models that user can choose from the drop-down are hard coded right now. I want to make use of the class ModelCatalog so that we will have the models available in the local machine in the drop down.
What do you think?

@Amna-28
Copy link
Contributor Author

Amna-28 commented Apr 9, 2022

Hi @miquelduranfrigola
I have made following changes:

  • placed all the files related to ersilia app under ersilia/app/contrib/
  • round the output to 3 decimals
  • Modified the drop-down code to include all the models that are available at local machine using local() method from ModelCatalog class.

Capture7
Capture9

@miquelduranfrigola
Copy link
Member

Amazing contribution, @Amna-28 ! I am very impressed. I am merging your PR right away. No need to work on this anymore at this stage. Many thanks!

Copy link
Member

@miquelduranfrigola miquelduranfrigola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic first contribution producing a Streamlit App for chemistry models

@miquelduranfrigola miquelduranfrigola merged commit 628d9f0 into ersilia-os:master Apr 9, 2022
@Amna-28
Copy link
Contributor Author

Amna-28 commented Apr 11, 2022

Thank you very much @miquelduranfrigola, means a lot.

gitbook-com bot pushed a commit that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants