Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model search functionality in the CLI #13

Closed
miquelduranfrigola opened this issue Mar 23, 2022 · 9 comments
Closed

Add model search functionality in the CLI #13

miquelduranfrigola opened this issue Mar 23, 2022 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@miquelduranfrigola
Copy link
Member

miquelduranfrigola commented Mar 23, 2022

Background

Ersilia models can be browsed on the web. Although we do not have a good interface now, this can be done through an Airtable base. There is no way to search/filter models using the CLI. As of now, the only thing that can be done is: ersilia catalog, which simply prints all models on a table.

Requested feature

We would like to have a search function in the ersilia CLI. For example: ersilia catalog search --text "antimicrobial" or ersilia catalog search --mode "pretrained"

@miquelduranfrigola miquelduranfrigola added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 23, 2022
@anamika-yadav99
Copy link
Contributor

Hi @miquelduranfrigola Can I work on this issue?

@martwebber
Copy link
Contributor

Hello @miquelduranfrigola, I would like to contribute to this.

@Riyabelle25
Copy link
Contributor

Hello, I have experience with Software Development for ML tools, and would love to contribute here! I have set up Ersilia and have been going through the codebase. I would like to tackle this issue, can I start working on a PR for the same?

@anamika-yadav99
Copy link
Contributor

anamika-yadav99 commented Mar 27, 2022

Hi @miquelduranfrigola I have looked into the codebase and worked around a little bit. I found that catalog already has --search option
image
I worked on creating a new cli feature search which searches through the catalog and finds the model with text or mode. It works like this
image
I'm a little confused with what is expected from this feature. Could you please provide a little bit more detail on this feature

@GemmaTuron
Copy link
Member

Hello @anamika-yadav99, @martwebber, @Riyabelle25

Thanks for your enthusiasm. Please, before continuing the work on this issue, refer to issue #36 and answer the questions there.
We also advise applicants to tackle one issue at a time, also leaving the opportunity to others to contribute. @Riyabelle25 and @anamika-yadav99 which issue are you most interested in pursuing? You have shown interest in a number of them.

@anamika-yadav99
Copy link
Contributor

Hi @GemmaTuron I would like to work on this issue #13.

@miquelduranfrigola
Copy link
Member Author

Thanks @anamika-yadav99! Thanks, and apologies for a confusing issue description.
The simplest will be to do the following:
ersilia catalog --text 'antimalarial'
and
ersilia catalog --mode 'pretrained'

@dauinh
Copy link
Contributor

dauinh commented Mar 29, 2022

Hi @miquelduranfrigola, can I be assigned to work on this issue?

@miquelduranfrigola
Copy link
Member Author

Hi @miquelduranfrigola, can I be assigned to work on this issue?

Hi @dauinh this issue has been solved and I am closing it now. Thanks for your interest!

miquelduranfrigola pushed a commit that referenced this issue Dec 21, 2023
added json object to store metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants