Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate disk usage of a model #7

Closed
miquelduranfrigola opened this issue Mar 21, 2022 · 4 comments
Closed

Calculate disk usage of a model #7

miquelduranfrigola opened this issue Mar 21, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@miquelduranfrigola
Copy link
Member

Background

When a model is downloaded with the fetch command, the corresponding GitHub repository is cloned, including Git LFS files. As of now, there is no way to know the size of the downloaded files before cloning. In addition, a conda environment or a docker container is created after download. We do not have a way of estimating the size of such environments/containers. Therefore, we are unable to inform the user about the size of the model they are about to fetch.

Requested feature

We would like to calculate total disk usage of a model before fetching it. This includes:

  • Size of files from GitHub (including Git LFS)
  • Size of conda environment or docker container
@miquelduranfrigola miquelduranfrigola added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 21, 2022
@Riyabelle25
Copy link
Contributor

Riyabelle25 commented Mar 27, 2022

Hey there!
I have experience with Software Development for ML tools, and would love to contribute here! I have set up Ersilia and have been going through the codebase. Can I take this up?

@GemmaTuron
Copy link
Member

Hello @Riyabelle25,

This is great thanks. To tackle this issue can you please first answer in issue #36 ?

@Riyabelle25
Copy link
Contributor

@GemmaTuron thanks!
I've made a PR to fix this issue first, will then move to the other issues I showed an interest in (if they're still open then)

@miquelduranfrigola
Copy link
Member Author

Hi @Riyabelle25 please refer to issue #6. If you want to contribute I will be happy to add you as an assignee! Many thanks for your amazing contributions. Closing issue now.

miquelduranfrigola pushed a commit that referenced this issue Dec 21, 2023
Add additional workflow steps to figure out the PR branch for a given comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants