-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track unused models and automatically delete them #8
Comments
Hi! |
Hello @Riyabelle25, As I mentioned, please first complete the requirements in issue #36. Then we advise you to choose one issue to start working with, either this one or issue #7 where you have also shown interest |
Hi! |
Hi @Amna-28 and @Riyabelle25! I see that both of you are showing interest in this task. Before implementing anything, I'd like to hear your thoughts, so that we are all on the same page (this issue may be a bit tricky to address). How would you like to approach this problem? (one or two lines will suffice :)) |
Hi there! |
I have been working on this task. |
Hi @Riyabelle25 and @Amna-28 - I am slowly catching up. You will see that I have a This is the right way to delete a model (@Riyabelle25 it will delete the local copy of the github repo indeed, among other things). @Amna-28 I really like your cronjob approach, as you know. I have no experience in this, but perhaps we could try this python library? https://pypi.org/project/python-crontab/ |
Hi @miquelduranfrigola can we do DVC on this issue to track the files and then remove it. I am still learning and searching to how make work remotely. Ease guide me :) |
Hi @Rufaida98 this is a great suggestion. We will certainly use DVC in the context of model data management (https://github.com/ersilia-os/isaura), but I feel the current solution, with cron jobs is good enough, because models are not being updated or anything - they just need to be removed after some time. |
@miquelduranfrigola oh I see thank you for the feedback 👍 |
Hi @miquelduranfrigola, I have a couple of doubts, If a model is already fetched and is in the local system,
|
Hi @sonali-sk thanks for the two questions. At the moment, by default when you fetch a model that is currently available in your system, the model is deleted and we fetch it again. We can certainly optimize this, perhaps just by using git functionalities. |
@miquelduranfrigola Is it being deleted so that the repo's last modify date is changed? Also, what I noticed initially is that when we try to fetch an already fetched model, it took lesser time compared to the current fetch mechanism, at that time was it fetching from the local system, due to which it took relatively less time? |
Good points, @sonali-sk. Fetching a second time takes less time in this case, probably because conda has already cached some packages. I do think that checking for the "last modified" data point in the repo would be a good way of avoiding unnecessary extra downloads. We haven't implemented it yet. Will keep you updated. |
Hi folks: |
Extracts model ID from metadata prints to console
Background
Most models in Ersilia require substantial disk usage. Deleting a model means removing all model files as well as the corresponding conda environment or docker container. A desirable feature would be to automatically remove models if they have not been used for e.g. a month.
Requested feature
Keep track of model last usage date, and delete it automatically if considered to be unused.
The text was updated successfully, but these errors were encountered: