Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ersilia conda-installable #9

Closed
miquelduranfrigola opened this issue Mar 21, 2022 · 8 comments
Closed

Make ersilia conda-installable #9

miquelduranfrigola opened this issue Mar 21, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@miquelduranfrigola
Copy link
Member

Background

Currently, Ersilia can be pip-installed. We have a GitHub Action to update ersilia on PyPi every time we do a new release. However, pip installation does not ensure that extra requirements (such as git-lfs) are installed. Perhaps having ersilia as a conda package would be desirable as well.

Requested feature

Make ersilia conda-installable and trigger a GitHub Action every to update the ersilia conda repository on every new release of the package.

@miquelduranfrigola miquelduranfrigola added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 21, 2022
@salma2vec
Copy link

Hi @miquelduranfrigola,
I'd like to work on this issue. Please assign it to me.

@anamika-yadav99
Copy link
Contributor

anamika-yadav99 commented Mar 28, 2022

Hi @miquelduranfrigola I tried to make this package conda installable but it keeps breaking down on conda build command. That's because there are dependencies which are not present on Conda. The problem is that conda package dependencies only refer to other conda packages. I also tried to repackage the dependencies not present on conda and then publish them in my channel but again, the conda build failed because they have dependencies which are not present on conda. For now, I have opened issues in dependencies which aren't on conda to make them conda package. Meanwhile, I'm also looking for work around this issue.
image

image

If there's something you know that could be helpful here?

@GemmaTuron
Copy link
Member

hello @IdealisticINTJ and @anamika-yadav99

Thanks for your interest to contribute to this. TPlease, first refer to issue #36 before continuing the work here.
@anamika-yadav99, please also go to issue #36 before and we will then work on this issue

@miquelduranfrigola
Copy link
Member Author

Hi @anamika-yadav99 thanks for your contribution here. These dependencies should be pip-installable, if I am not mistaken. If you install pip in the conda environment, is it possible to then install these packages with the pip command?

@anamika-yadav99
Copy link
Contributor

@miquelduranfrigola Yes the dependencies are pip-installable but they aren't conda-installable. Dependencies are required to be conda installable to build a conda package.

@miquelduranfrigola
Copy link
Member Author

Hi @anamika-yadav99 thanks a lot. The conda skeleton solution that you suggest seems to be a good option: https://stackoverflow.com/questions/64916092/how-do-i-install-pip-packages-through-a-conda-build-recipe

@anamika-yadav99
Copy link
Contributor

Hi @miquelduranfrigola I'm on it.

@miquelduranfrigola
Copy link
Member Author

Hi @anamika-yadav99 I am closing the issue now. All is well noted and some folk volunteers who are writing Github Actions with us will use your contribution. So I greatly appreciate it.

Will reopen in case any problems emerge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants