Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #12
I have improved the model display according to discussion in comment #12 (comment)
I have added a function to slice the catalog table into table of 15. Table size of 25 was huge.
I have also added
ersilia catalog --next
andersilia catalog --previous
in cli which displays the next and previous table consequently.I have done so by storing a variable called counter in an auxiliary file which is initialized to 1 everytime
ersilia catalog
is called. Wheneverersilia catalog --next
is called the counter is updated by 1 and displays the next table. Vise versa happens inersilia catalog --previous
. Counter is decreased by 1.Implementing this was a little tricky due to all the corner cases of reaching the last table or
ersilia catalog --previous
on the 1st table. So, I have set the value of counter to 1 every time the table is on the 1st page. The user is informed about the last page table. The counter is decreased by 2 when on the last page in order to not display the same page. I hope all the corner cases are covered.This is how it looks. Table size of only 5 was used here because ersilia hub has only 21 models, which made it hard to check for the corner cases:
![image](https://user-images.githubusercontent.com/54634163/163671749-bdd9f826-d458-4154-b857-74d01876ac81.png)