ModelSearcher updated #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
miquelduranfrigola
approved these changes
May 9, 2022
|
Hi @anamika-yadav99 this is great stuff. I have approved the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #241
I have added 2 methods to ModelSearcher Class to search using
--textand--mode. To search using--textsearch_text method is added which also performs fuzzy match on the input to the data in catalog table. Fuzzy match is performed on model_id, description and slug.search_mode method is kept same as previous search which searches the mode by which the model was trained. It doesn't perform any string matching.
Also, when no match is found user is asked to look through the catalog