Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(inbox): email function improvement #4433

Merged
merged 30 commits into from Jun 6, 2023
Merged

perf(inbox): email function improvement #4433

merged 30 commits into from Jun 6, 2023

Conversation

ariunzayarin
Copy link
Collaborator

No description provided.

@ariunzayarin ariunzayarin self-assigned this May 26, 2023
@gitguardian
Copy link

gitguardian bot commented May 26, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
255534 Redis Credentials 868de61 create-erxes-app/bin/create-erxes-app.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Anu-Ujin Anu-Ujin merged commit 105ca0f into staging Jun 6, 2023
21 of 22 checks passed
@Anu-Ujin Anu-Ujin deleted the perf-inbox branch June 6, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants