Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards little fix #4683

Merged
merged 23 commits into from Oct 17, 2023
Merged

Cards little fix #4683

merged 23 commits into from Oct 17, 2023

Conversation

ariunzayarin
Copy link
Collaborator

No description provided.

@gitguardian
Copy link

gitguardian bot commented Oct 13, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
255534 Redis Credentials 868de61 create-erxes-app/bin/create-erxes-app.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@cypress
Copy link

cypress bot commented Oct 13, 2023

1 failed test on run #242 ↗︎

1 6 4 0 Flakiness 0

Details:

Merge 4f85287 into 0af0d0b...
Project: erxes Commit: d80b8c1c17 ℹ️
Status: Failed Duration: 02:40 💡
Started: Oct 17, 2023 11:11 AM Ended: Oct 17, 2023 11:14 AM
Failed  cypress/tests/contacts/ui/customer.cy.js • 1 failed test

View Output Video

Test Artifacts
Customer > add customer Output Screenshots Video

Review all test suite changes for PR #4683 ↗︎

@Anu-Ujin Anu-Ujin merged commit ad3c058 into dev Oct 17, 2023
24 of 26 checks passed
@Anu-Ujin Anu-Ujin deleted the cards-little-fix branch October 17, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants