init #4941
init #4941
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9241816 | Triggered | Generic High Entropy Secret | 538941e | packages/plugin-syncpolaris-api/src/utils/utils.ts | View secret |
| 9241816 | Triggered | Generic High Entropy Secret | cfe94cb | packages/plugin-syncpolaris-api/src/utils/utils.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces enhancements to the contracts form component, including improved optional chaining for better null safety, mapping of weekend values to numbers, and handling of custom payment values. It also includes updates to the GraphQL resolvers and configurations for the ZMS plugin.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
- Big diff: the diff is too large to approve with confidence.
General suggestions:
- Verify TypeScript version compatibility for the use of optional chaining with array index access to ensure it is supported.
- Add checks to ensure that the 'weekends' array does not contain null or undefined values before converting them to numbers to prevent runtime errors.
- Consider using the nullish coalescing operator instead of the logical OR for default values to correctly handle cases where '0' is a valid value.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| @@ -154,7 +156,7 @@ class ContractForm extends React.Component<Props, State> { | |||
| customInterest: contract.customInterest || 0, | |||
| customPayment: contract.customPayment || 0, | |||
| currency: | |||
| contract.currency || this.props.currentUser.configs?.dealCurrency[0], | |||
| contract.currency || this.props.currentUser?.configs?.dealCurrency?.[0], | |||
There was a problem hiding this comment.
issue (llm): The use of optional chaining with array index access should be verified for TypeScript version compatibility. If the project's TypeScript version is below 3.7, this syntax will not be supported.
| @@ -232,7 +234,7 @@ | |||
| leaseType: this.state.leaseType, | |||
| savingContractId: this.state.savingContractId, | |||
| commitmentInterest: this.state.commitmentInterest, | |||
| weekends: this.state.weekends.map(week => Number(week)), | |||
| weekends: this.state.weekends.map((week) => Number(week)), | |||
There was a problem hiding this comment.
issue (llm): Ensure that the 'weekends' array cannot contain null or undefined values which could cause runtime errors when calling 'Number' on them.
| ); | ||
| const customPayment = Number( | ||
| name === 'customPayment' ? value : this.state.customPayment || 0 | ||
| name === 'customPayment' ? value : this.state.customPayment || 0, |
There was a problem hiding this comment.
suggestion (llm): The logical OR operator might lead to unexpected results if 'this.state.customPayment' is 0. Consider using nullish coalescing operator (??) to handle 0 as a valid value.
|
sync polaris