Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throws on valid syntax #8

Closed
Trott opened this issue Apr 24, 2022 · 1 comment
Closed

throws on valid syntax #8

Trott opened this issue Apr 24, 2022 · 1 comment

Comments

@Trott
Copy link

Trott commented Apr 24, 2022

This bug does not exist in 0.22.1 but is in 0.28.0.

Code being processed:

(function(exports, require, module, __filename, __dirname) {
// Module code actually lives in here
});

Expected result is successful parsing and that's what we see in 0.22.1.

With 0.28.0, we end up with a TypeError:

TypeError: Cannot read properties of null (reading 'type')
Occurred while linting /home/runner/work/node/node/doc/api/modules.md/10_10.js:1
Rule: "jsdoc/check-access"
    at getReducedASTNode (/home/runner/work/node/node/tools/node_modules/eslint/node_modules/@es-joy/jsdoccomment/dist/index.cjs.cjs:587:24)
    at *:not(Program) (/home/runner/work/node/node/tools/node_modules/eslint/node_modules/eslint-plugin-jsdoc/dist/iterateJsdoc.js:948:67)
    at ruleErrorHandler (/home/runner/work/node/node/tools/node_modules/eslint/lib/linter/linter.js:11[14](https://github.com/nodejs/node/runs/6144635885?check_suite_focus=true#step:5:14):28)
    at /home/runner/work/node/node/tools/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/home/runner/work/node/node/tools/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/home/runner/work/node/node/tools/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
    at NodeEventGenerator.applySelectors (/home/runner/work/node/node/tools/node_modules/eslint/lib/linter/node-event-generator.js:324:[22](https://github.com/nodejs/node/runs/6144635885?check_suite_focus=true#step:5:22))
    at NodeEventGenerator.enterNode (/home/runner/work/node/node/tools/node_modules/eslint/lib/linter/node-event-generator.js:340:14)
    at CodePathAnalyzer.enterNode (/home/runner/work/node/node/tools/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:795:[23](https://github.com/nodejs/node/runs/6144635885?check_suite_focus=true#step:5:23))

References:
@Trott Trott mentioned this issue Apr 24, 2022
Merged
@brettz9
Copy link
Contributor

brettz9 commented Apr 24, 2022

Fixed in 92a36cb . I released v0.28.1 but then also released v0.29.0 because I noticed our engines wasn't properly reflecting current behavior (that we don't support Node 12).

I've updated eslint-plugin-jsdoc to use v0.29.0 as v39.2.8. Closing as should resolve. Thanks for the report!

@brettz9 brettz9 closed this as completed Apr 24, 2022
Trott added a commit to Trott/io.js that referenced this issue Apr 25, 2022
@Trott
tools: bump jsdoccomment from 0.22.1 to 0.29.0
5fd14fd 
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8
@Trott Trott mentioned this issue Apr 25, 2022
Merged
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Apr 25, 2022
@Trott
tools: bump jsdoccomment from 0.22.1 to 0.29.0
2691222 
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: #42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Apr 28, 2022
@Trott @targos
tools: bump jsdoccomment from 0.22.1 to 0.29.0
c3c5fe7 
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: #42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
juanarbol pushed a commit to nodejs/node that referenced this issue May 31, 2022
@Trott @juanarbol
tools: bump jsdoccomment from 0.22.1 to 0.29.0
ecb4d0b 
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: #42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Jun 27, 2022
@Trott @danielleadams
tools: bump jsdoccomment from 0.22.1 to 0.29.0
7b6b92e 
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: #42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Jul 12, 2022
@Trott @targos
tools: bump jsdoccomment from 0.22.1 to 0.29.0
7a1588d 
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: #42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Jul 31, 2022
@Trott @targos
tools: bump jsdoccomment from 0.22.1 to 0.29.0
e8ef4f2 
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: #42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
@Trott @guangwong
tools: bump jsdoccomment from 0.22.1 to 0.29.0
714d53b 
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: nodejs/node#42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettz9 @Trott