Fix failing standard implementations #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art of the tests should be ensuring that we're overriding the native methods whenever necessary.
|
Failures are known. Merging now. |
ljharb
added a commit
that referenced
this pull request
Apr 17, 2014
Fix failing standard implementations. Closes #219.
ljharb
added a commit
that referenced
this pull request
Apr 17, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be killing native methods just for tests.
This leaves 4 failures in node, 4 in Chrome, 16 in Safari, and 2 in Firefox. All but 1 of the Firefox ones are related to Date.parse.
I plan to merge this, and then fix Date.parse in a separate branch.