Add information about patching order when using ES compatibility shim… #379
Conversation
| ```html | ||
| <script src="es5-shim.js"></script> | ||
| <script src="es5-sham.js"></script> | ||
| <script src="json3.js"></script> |
There was a problem hiding this comment.
i don't even think this is necessary, but it should still be done after all the other es shims.
There was a problem hiding this comment.
As json3 is ECMA5.1, then it seems correct to go after es5-shim, I believe es6-shim also patches the ECMA5.1 JSON object, which won't happen if it were after all the es shims?
https://github.com/paulmillr/es6-shim/blob/master/es6-shim.js#L3668
There was a problem hiding this comment.
ah, if json3 is in fact ES5.1 with nothing extra then sure, why not.
we should probably link all of these to cdnjs so that the examples are copypasteable
There was a problem hiding this comment.
https://github.com/bestiejs/json3
Well it claims to be (unless I am mistaken), and the tests seem to prove that it is, unlike JSON2. I can add the cdn links, cdnjs and current versions?
There was a problem hiding this comment.
cdn links to the "latest" versions seem like the best choice.
There was a problem hiding this comment.
There is no cdnjs for es7-shim yet. And cdnjs does not have a "latest" option unfortunately (not that I could find), it's by release version.
| <script src="https://cdnjs.cloudflare.com/ajax/libs/json3/3.3.2/json3.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/es6-shim/0.34.2/es6-shim.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/es6-shim/0.34.2/es6-sham.min.js"></script> | ||
| <script src="es7-shim.js"></script> |
There was a problem hiding this comment.
for this one, you'd want to use https://wzrd.in/standalone/es7-shim@latest which will autoshim
…s, along with an example. es-shims#377 Add cdnjs links for latest available versions Add ed7-shim url and update es5-shim version
|
Thanks! |
…s, along with an example. #377