Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fix: Accessing window.top.{constructor|prototype} from a frame throws error in iOS #445

Merged
merged 1 commit into from
Jul 11, 2017
Merged

馃悰 Fix: Accessing window.top.{constructor|prototype} from a frame throws error in iOS #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion es5-shim.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,7 +994,8 @@
$webkitStorageInfo: true,
$external: true,
$width: true,
$height: true
$height: true,
$top: true
};
var hasAutomationEqualityBug = (function () {
/* globals window */
Expand Down
2 changes: 1 addition & 1 deletion tests/spec/s-object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ describe('Object', function () {

ifWindowIt('can serialize all objects on the `window`', function () {
var windowItemKeys, exception;
var excludedKeys = ['window', 'console', 'parent', 'self', 'frame', 'frames', 'frameElement', 'external', 'height', 'width'];
var excludedKeys = ['window', 'console', 'parent', 'self', 'frame', 'frames', 'frameElement', 'external', 'height', 'width', 'top'];
if (supportsDescriptors) {
Object.defineProperty(window, 'thrower', {
configurable: true,
Expand Down