nsga2 batch fitness evaluation (bfe) #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR, can you fix the CI failures? Mainly related to dangerous conversions among int types? |
|
Yes, I'll be glad to sort these out. Thanks for drawing my attention to them as I haddn't noticed.
…On 2019-06-15 22:12, Dario Izzo wrote:
Thanks for this PR, can you fix the CI failures? Mainly related to
dangerous conversions among int types?
--
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [1], or mute the
thread [2].
Links:
------
[1]
#308?email_source=notifications&email_token=AISL5WTHACTXICFUNEFSAJ3P2VLNFA5CNFSM4HYPNPZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZAGLA#issuecomment-502399788
[2]
https://github.com/notifications/unsubscribe-auth/AISL5WW3LMMS5R22KG3EXOTP2VLNFANCNFSM4HYPNPZA
|
|
All done. Sorry I overlooked them before. |
bluescarni
reviewed
Jun 18, 2019
src/algorithms/nsga2.cpp
Outdated
|
|
||
| poptemp.push_back(child1); | ||
| poptemp.push_back(child2); | ||
| //popnew.push_back(child1, f1); |
There was a problem hiding this comment.
@willcodeforfudd can these commented lines be removed?
There was a problem hiding this comment.
Yes, of course. Sorry for the sloppy code, and repeated commits - this is my first time collaborating on a github project.
There was a problem hiding this comment.
@willcodeforfudd no worries, thanks for contributing the code. I am trying to ping @darioizzo to see if he can give the final OK for merging.
|
@willcodeforfudd thanks for the PR! I had a small comment, but otherwise it looks good to me 👍 |
darioizzo
requested changes
Jun 21, 2019
darioizzo
approved these changes
Jun 26, 2019
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that these are the minimal changes to get working with bfe on nsga2