Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for folder name, image name NPE #316

Merged
merged 3 commits into from Feb 14, 2021
Merged

Conversation

RationalRank
Copy link
Contributor

@RationalRank RationalRank commented Dec 7, 2020

Folder and Image are made kotlin data models in the previous release. Still, the client code (DefaultImageFileLoader) is in Java, and it creates an instance of these models without not null validation.
This PR fixes #310, #311, #315

@esafirm
Copy link
Owner

esafirm commented Feb 5, 2021

Didn't know the image name could be null 🤔
I'll need to fix the CI first, will inform you soon

Thanks for the PR!

@esafirm esafirm merged commit 0b307a3 into esafirm:main Feb 14, 2021
@esafirm esafirm mentioned this pull request Feb 18, 2021
india2sarthak pushed a commit to india2sarthak/android-image-picker that referenced this pull request Sep 1, 2023
* Fix for folder name, image name NPE

* Fix for folder name, image name NPE

* Code style updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException
2 participants