Fix display video duration cause app crash when targeting to sdk 29 and fix display media file under root in folder mode #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiwuwa
changed the title
|
Fix cannot display media file under root in folder mode |
|
@esafirm I am also facing related issue in latest version |
esafirm
requested changes
Mar 1, 2021
...picker/src/main/java/com/esafirm/imagepicker/features/fileloader/DefaultImageFileLoader.java
Outdated
Show resolved
Hide resolved
|
Thanks @wiwuwa LGTM 👍 |
|
This issue still happened with 2.4.5, retriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_DURATION) is getting null which resulted in NumberFormatException with Long.parseLong Running on Android 10 with app targeting SDK version 30 |
|
@siva-komaragiri will add the fix to version 3.0.0 |
|
There have other issue related to this |
india2sarthak
pushed a commit
to india2sarthak/android-image-picker
that referenced
this pull request
Sep 1, 2023
…nd fix display media file under root in folder mode (esafirm#331) * Fix display video duration app crash bug for targeting to sdk 29 * Fix cannot display media file right under root directory in Folder mode (esafirm#333) * simplify further null-proof the code (suggested by esafirm) Co-authored-by: sli <sli@nexify.com.hk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Android Q cannot open gallery when the directory contains video