Toolbar Done button visibility. #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ton always or not.
esafirm
requested changes
Apr 3, 2021
| @@ -40,4 +40,8 @@ object ConfigUtils { | |||
| val doneButtonText = config.doneButtonText | |||
| return if (doneButtonText.isNullOrBlank()) context.getString(R.string.ef_done) else doneButtonText | |||
| } | |||
|
|
|||
| fun getDoneButtonTextVisibility(config: ImagePickerConfig): Boolean { | |||
There was a problem hiding this comment.
You don't need helper function if it just accessing a property
| @@ -7,4 +7,5 @@ abstract class BaseConfig { | |||
| abstract var savePath: ImagePickerSavePath | |||
| abstract var returnMode: ReturnMode | |||
| abstract var isSaveImage: Boolean | |||
| abstract var showDoneButtonAlways: Boolean | |||
There was a problem hiding this comment.
I think you should only add this in ImagePickerConfig since it's not affecting CameraOnly functionality?
dilip786
commented
Apr 5, 2021
|
@esafirm Can you please have a look at my pr as this is blocker to my release. thanks in advance. |
|
LGTM 👍 Thanks for the PR @dilip786 |
|
Packagin this as |
|
Thanks Esafirm/Android-Image-Picker
…On Thu, 8 Apr, 2021, 7:51 am Esa Firman, ***@***.***> wrote:
Packagin this as 3.0.0-alpha2 @dilip786 <https://github.com/dilip786>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#347 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACRKBYCK3WHEUT4PSCZR7V3THUHJPANCNFSM42INRCYA>
.
|
|
Hey, Unable to import this package 3.0.0-alpha2, When i try to Gradle Sync, the Dependency is not resolvable.. Can you help on this pls
|
|
The artifact is now |
|
Can it be released also as part of the v2 release train? Thank you @esafirm 🥇 |
india2sarthak
pushed a commit
to india2sarthak/android-image-picker
that referenced
this pull request
Sep 1, 2023
* Added a new variable in ImagePickerConfig.kt Whether to show Done button always or not. * Code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new variable in ImagePickerConfig.kt Whether to show Done button or not always, We already had a chat on this and here is the bug link [(https://github.com//issues/339 )].
This is blocker to my release, Please have a look and let me know if you need any changes.