Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fragment not attached to context exception #363

Merged
merged 2 commits into from
Jun 10, 2021
Merged

fix fragment not attached to context exception #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afb9e94
-fix fragment not attached to context exception
michaelsam94 Jun 1, 2021
8589b7d
-fix toolbar cast exception in CustomUIActivity.kt
michaelsam94 Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion imagepicker/src/main/java/com/esafirm/imagepicker/features/ImagePickerLauncher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ class ImagePickerLauncher(
typealias ImagePickerCallback = (List<Image>) -> Unit

fun Fragment.registerImagePicker(
context: Context,
callback: ImagePickerCallback
): ImagePickerLauncher {
return ImagePickerLauncher(requireContext(), createLauncher(callback))
return ImagePickerLauncher(context, createLauncher(callback))
}

fun ComponentActivity.registerImagePicker(
Expand Down
2 changes: 1 addition & 1 deletion sample/src/main/java/com/esafirm/sample/CustomUIActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class CustomUIActivity : AppCompatActivity() {
}

private fun setupView() {
setSupportActionBar(binding.toolbar as Toolbar)
setSupportActionBar(binding.toolbar.root as Toolbar)
checkNotNull(supportActionBar)

actionBar = supportActionBar!!
Expand Down
21 changes: 12 additions & 9 deletions sample/src/main/java/com/esafirm/sample/MainFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,27 @@
package com.esafirm.sample

import android.content.Context
import android.os.Bundle
import android.view.View
import androidx.fragment.app.Fragment
import com.bumptech.glide.Glide
import com.esafirm.imagepicker.features.ImagePickerConfig
import com.esafirm.imagepicker.features.ImagePickerMode
import com.esafirm.imagepicker.features.ReturnMode
import com.esafirm.imagepicker.features.registerImagePicker
import com.esafirm.imagepicker.features.*
import com.esafirm.sample.databinding.FragmentMainBinding

class MainFragment : Fragment(R.layout.fragment_main) {

private lateinit var binding: FragmentMainBinding

private val imagePickerLauncher = registerImagePicker {
val firstImage = it.firstOrNull() ?: return@registerImagePicker
Glide.with(binding.imgFragment)
.load(firstImage.uri)
.into(binding.imgFragment)
private lateinit var imagePickerLauncher: ImagePickerLauncher

override fun onAttach(context: Context) {
super.onAttach(context)
imagePickerLauncher = registerImagePicker(context) {
val firstImage = it.firstOrNull() ?: return@registerImagePicker
Glide.with(binding.imgFragment)
.load(firstImage.uri)
.into(binding.imgFragment)
}
}

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
Expand Down