Optimize load images #364
Merged
Optimize load images #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove mvp view
india2sarthak
pushed a commit
to india2sarthak/android-image-picker
that referenced
this pull request
Sep 1, 2023
* optimize load images remove mvp view * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
1. Optimize image files loading
Previously, we load all files at once and then show them to the UI. This works but if we have a lot of files, it can take quite some time. Now, we strategize to load a small number of files first, after that if the devices still have more files, we load all of them and update the list.
2. Change the MVP pattern
3. Add more test